Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No event bus used for Ctrl+S #11657

Closed
Dreamsorcerer opened this issue Mar 3, 2020 · 0 comments · Fixed by #11826
Closed

No event bus used for Ctrl+S #11657

Dreamsorcerer opened this issue Mar 3, 2020 · 0 comments · Fixed by #11826
Labels

Comments

@Dreamsorcerer
Copy link

Dreamsorcerer commented Mar 3, 2020

This is a minor niggle, but it seems like there is a good way to run code whenever the user downloads or prints, by using PDFViewerApplication.eventBus.on("download", ..) and PDFViewerApplication.eventBus.on("beforeprint", ..). This works if the user clicks the download or print button, and works with Ctrl+P for print.

However, Ctrl+S to trigger the download does not use the eventBus. It would be nice to also use the eventBus here, so there is a single point to hook onto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants