create-react-app example uses a fake worker

[artdent]

Configuration:

• PDF.js version: 2.4.456

Steps to reproduce the problem:

1. cd examples/create-react-app
2. npm install && npm start
3. Open the js console
4. Observe Warning: Setting up fake worker.

What is the expected behavior?
Example loads pdfjs.worker as an actual web worker

What went wrong?
A fake worker was used

Currently, examples/create-react-app/package.json depends on pdfjs-dist version 2.2.228, but I upgraded it to 2.4.456 and observed the same behavior.

A workaround is to serve the js worker statically in the public/, but it would be nice if the example included in the pdf.js repository were working out of the box.

[Snuffleupagus]

Observe Warning: Setting up fake worker.

Looking at

pdf.js/examples/create-react-app/src/pdf.tsx

Lines 5 to 7 in b86df97

	import pdfjsWorker from 'pdfjs-dist/build/pdf.worker.entry';
	pdfjs.GlobalWorkerOptions.workerSrc = pdfjsWorker;

and then https://github.com/mozilla/pdfjs-dist/blob/a3a0d672c2f3464e4bff95ad0a3b41341eb65a26/build/pdf.worker.entry.js, the example looks trivially wrong since that's obviously not how workerSrc can/should be used (given that it should be assigned a string).

Currently, examples/create-react-app/package.json depends on pdfjs-dist version 2.2.228,

Having the version number hard-coded really isn't good :-(

---

The general problem with the create-react-app example is that none of the few regular PDF.js contributors know much (or even anything) about React.
Consequently it's very difficult for us to maintain that example, not to mention provide support for it, and I do wonder if having it ends up does more harm than good!? @timvandermeij Should we perhaps consider removing that example?

[timvandermeij]

/cc @luistak Would you perhaps be willing to update the example given the feedback in this issue?