-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracking] Back-port patches to the current PDF.js pre-release (v2.4.456) #11801
Comments
Let's indeed see if more people run into problems with this before making a final decision. |
It's now been well over a month since the pre-release was made, and thus far no serious regressions have been reported. I think that we should now make a decision here, either to:
|
Given that it's mentioned in the release notes, I'm not how necessary it is to backport those patches. If we decide to do so, I'm not entirely sure what the process for that is. I think we can remove the current pre-release and make a new one without doing the version bump, but I'm not sure if that will mess up the releases on e.g. NPM? /cc @brendandahl Any ideas for this? |
Actually, rather than messing with the existing release it might make more sense to simply just create a new "normal" one instead!? Basically, create a new pre-release ( |
Good plan. I'll try to do this soon since there is a demand for the new version. |
When the next release is done, we should also remember to revert the current special-casing at https://mozilla.github.io/pdf.js/getting_started/#download as well. |
One of the most significant changes in the current PDF.js pre-release, see https://github.com/mozilla/pdf.js/releases/tag/v2.4.456, is that we're now producing two kind of builds (with/without Babel translation and polyfills).
This has lead to some issues and/or support questions, since the default PDF.js builds are no longer directly compatible with "all" browsers/environments.
Hence we may want to consider back-porting only the following patches (the list below is subject to change), using
git cherry-pick
, to thev2.4.456
pre-release and then replace it with a new version.GENERIC
builds, if certain required browser functionality is missing (issue 11762) #11771GENERIC
builds, if certain required browser functionality is missing (PR 11771 follow-up) #11799document
(PR 10318 follow-up, issue 11829) #11837Given that the release was done less than a month ago, as of this writing, we probably want to wait a bit before making a final decision (there may be additional issues/regressions that should be addressed).
While I don't have any data and/or statistics to back up this claim, but based on experience it seems that many (most?) users will only ever use "stable" releases. Hence fixing these issues at the pre-release stage seem much simpler, rather than having them reach an actual release version (which is why I opened this tracking issue).
The text was updated successfully, but these errors were encountered: