Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong display and invalid values in AP dictionary of radio button group when filled/saved #12654

Closed
JanSlabon opened this issue Nov 24, 2020 · 5 comments · Fixed by #12655
Closed

Comments

@JanSlabon
Copy link

Attach (recommended) or Link to PDF file here:
Subscription-tekMag.pdf
Subscription-tekMag-filled-by-pdfjs.pdf

Configuration:

  • Web browser and its version: FF 83.0
  • Operating system and its version: Windows 10 Pro
  • PDF.js version: 2.7.99 / 2.7.295
  • Is a browser extension: yes / no

Steps to reproduce the problem:

  1. Open document Subscription-tekMag.pdf
  2. See the wrong rendered appearances
  3. Choose a subscription through the radio button group (Choose your Subscription)
  4. Save the document (STRG+S)

What is the expected behavior?
grafik

What went wrong?
grafik

Also when the file is saved the AP dictionary has invalid data and the radio button groups are not useable anymore. E.g.:

/N << /2#20years,#2024#20issues#20(digital#20download#20only) 162 0 R>>

Looks like the name is not escaped correctly.

(The checkbox at the end has also a strange behavior (always locked when saved) - ping me, if I should open an additional issue for this one)

@meet-aniket
Copy link

Hi i wanna do work on this issue please assign it to me. Please notice this point that i came first on this issue so please do assign it to me to work.

@timvandermeij
Copy link
Contributor

There is already a PR for this (see above).

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 25, 2020

The escaping is fixed by the PR above. Please open a new issue for any remaining issues so we have one problem per issue. Thanks.

@JanSlabon
Copy link
Author

Looks like the checkbox was fixed by the same PR. I guess that the appearances are not used is an already known/reported issue/known limitation?

@timvandermeij
Copy link
Contributor

Ah yes, that would be #12234, so I think everything here is either fixed or tracked in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants