Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin drawing pages while still downloading data? #1375

Closed
gigaherz opened this issue Mar 21, 2012 · 7 comments
Closed

Begin drawing pages while still downloading data? #1375

gigaherz opened this issue Mar 21, 2012 · 7 comments
Labels

Comments

@gigaherz
Copy link
Contributor

I haven't seen any issue about this, but it would be an important feature to allow people to begin reading the PDF while it's still downloading. It's not uncommon for me to have multiple related PDFs and forget which one of them contains the text I'm looking for, and waiting for the PDF to complete donwloading before I can check if it's even the right one kills the mood.

Also, even if there's no clear UI design yet, it woudl be interesting to have a progressbar shown under the load %.
(and since I was bored, I wrote a class to implement a simple progressbar, lib-free: http://jsfiddle.net/3wmte/)

@jviereck
Copy link
Contributor

I haven't seen any issue about this, but it would be an important feature to allow people to begin reading the PDF while it's still downloading.

Is this #1108?

Also, even if there's no clear UI design yet, it woudl be interesting to have a progressbar shown under the load %.
(and since I was bored, I wrote a class to implement a simple progressbar, lib-free: http://jsfiddle.net/3wmte/)

That sounds like a good idea :) Want to make a pull request?

@gigaherz
Copy link
Contributor Author

Related, but not exactly, #1108 is about only requesting what you need, this would be about downloading the whole file eventually, but begin drawing as soon as there's enough info to draw the first page, not keep the loading progress until the end, and then begin drawing afterwards.

Maybe the implementation would need to be shared, if drawing before it's done requires splitting the file into multiple requests...

About the progressbar, I suppose it wouldn't be too complicated to do it, so I'll try in a bit.

@jviereck
Copy link
Contributor

Related, but not exactly, #1108 is about only requesting what you need, this would be about downloading the whole file eventually, but begin drawing as soon as there's enough info to draw the first page, not keep the loading progress until the end, and then begin drawing afterwards.

you're right - the difference is about downloading everything against downloading only parts. However, as much as I can think about it in pure theory without having done any implementation yet, there shouldn't be too much difference in the way this gets implemented.

@gigaherz, it needs some more time to explain exactly why I think this is the case. If you want to understand what's going on, you have read #1108 and there are still open questions, I'm more then happy to get you up to speed on this issue.

@timvandermeij
Copy link
Contributor

Hasn't this been tackled by #2719?

@Snuffleupagus
Copy link
Collaborator

Hasn't this been tackled by #2719?

To some degree, I think it has, but #3164 might be related as well.

@timvandermeij
Copy link
Contributor

Chunked rendering has also been implemented by #3461, so I guess we can close this, @brendandahl?

@yurydelendik
Copy link
Contributor

yep, we can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants