Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of transform in the annotation layer #14935

Closed
calixteman opened this issue May 19, 2022 · 0 comments · Fixed by #15036
Closed

Get rid of transform in the annotation layer #14935

calixteman opened this issue May 19, 2022 · 0 comments · Fixed by #15036
Assignees

Comments

@calixteman
Copy link
Contributor

calixteman commented May 19, 2022

We have few bugs in Firefox because of that, the last I filed:
https://bugzilla.mozilla.org/show_bug.cgi?id=1770132

We could replace them with stuff like:

  top: calc(... * var(--zoom-factor));
  left: calc(... * var(--zoom-factor));
 ...

We already use this trick in order to set the font size in options:

const fontSizeStyle = `calc(${fontSize}px * var(--zoom-factor))`;

This way we could do the zoom stuff almost only thanks to css instead of relying on js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant