-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rimraf
to version 5.0.0+
#16337
Comments
Given that the previous update attempt broke the release-process, i.e. the @timvandermeij To improve the release-process, how feasible would #11851 (comment) be and would you perhaps be able to look into that? |
rimraf
to version 5rimraf
to version 5.0.0+
Yes, that one is next on my list since it's indeed becoming more important to get at least the first steps done there given the flaky release process lately. I hope I'll have time for this in the coming week. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
rimraf
to version 5.0.0+rimraf
to version 5.0.0+
Storing a reference to #17696 here as it might be an alternative to get rid of |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I guess this could be closed now :) |
Almost, but we still need to remove |
In PR #15925
rimraf
was updated from version 3 to version 4, but unfortunately this caused some breakage due to the removed glob functionaly (see #15925 (comment)) and was consequently reverted in #16118.However, in
rimraf
4.2 the glob functionality was restored (see https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md and isaacs/rimraf#249 (comment)), so this update can be reattempted. Note that version 5 only removed the default export, so we might as well go to that newest version directly from version 3./cc @Snuffleupagus in case you're interested since you provided the previous PR which can hopefully be made to work now by providing the
glob
option to the places where we use globs.The text was updated successfully, but these errors were encountered: