Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rimraf to version 5.0.0+ #16337

Closed
timvandermeij opened this issue Apr 23, 2023 · 10 comments · Fixed by #18106
Closed

Upgrade rimraf to version 5.0.0+ #16337

timvandermeij opened this issue Apr 23, 2023 · 10 comments · Fixed by #18106

Comments

@timvandermeij
Copy link
Contributor

timvandermeij commented Apr 23, 2023

In PR #15925 rimraf was updated from version 3 to version 4, but unfortunately this caused some breakage due to the removed glob functionaly (see #15925 (comment)) and was consequently reverted in #16118.

However, in rimraf 4.2 the glob functionality was restored (see https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md and isaacs/rimraf#249 (comment)), so this update can be reattempted. Note that version 5 only removed the default export, so we might as well go to that newest version directly from version 3.

/cc @Snuffleupagus in case you're interested since you provided the previous PR which can hopefully be made to work now by providing the glob option to the places where we use globs.

@Snuffleupagus
Copy link
Collaborator

Given that the previous update attempt broke the release-process, i.e. the gulp dist part, I'd suggest that we don't try to update rimraf again until the releases are sorted out first.

@timvandermeij To improve the release-process, how feasible would #11851 (comment) be and would you perhaps be able to look into that?

@timvandermeij timvandermeij changed the title Update rimraf to version 5 Update rimraf to version 5.0.0+ Apr 23, 2023
@timvandermeij
Copy link
Contributor Author

Yes, that one is next on my list since it's indeed becoming more important to get at least the first steps done there given the flaky release process lately. I hope I'll have time for this in the coming week.

@ojuschugh1

This comment was marked as outdated.

@Snuffleupagus

This comment was marked as outdated.

@ojuschugh1

This comment was marked as outdated.

@timvandermeij timvandermeij changed the title Update rimraf to version 5.0.0+ Upgrade rimraf to version 5.0.0+ Apr 11, 2024
@timvandermeij
Copy link
Contributor Author

timvandermeij commented Apr 12, 2024

Storing a reference to #17696 here as it might be an alternative to get rid of rimraf altogether, and the new versions of rimraf also seem to simply re-export the Node.js ones already looking at https://github.com/isaacs/rimraf/blob/d2fa213e3ea1cc056698f9cac648b6e68796ea36/src/fs.ts#L5-L15 and isaacs/rimraf#224 (comment).

@Snuffleupagus

This comment was marked as resolved.

@timvandermeij

This comment was marked as resolved.

@wojtekmaj
Copy link
Contributor

I guess this could be closed now :)

@timvandermeij
Copy link
Contributor Author

Almost, but we still need to remove rimraf from the Gulpfile. I deliberately removed it from the test code first to keep the steps small and easier to test, given the complications we've had with rimraf before as mentioned in the original description above. But indeed, removing it is preferred over upgrading it now, and we're almost there :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants