We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading from the source code:
pdf.js/src/display/annotation_layer.js
Line 2846 in 57d196e
it appears to me it was not an intention to mark downloadManager as a required parameter in AnnotationLayerParameters:
Line 63 in 57d196e
and AnnotationLayerBuilderOptions:
pdf.js/web/annotation_layer_builder.js
Line 40 in 57d196e
and it should be optional, similarly to accessibilityManager for example:
pdf.js/web/text_layer_builder.js
Line 30 in 57d196e
Configuration:
What is the expected behavior? (add screenshot)
downloadManager to be optional
downloadManager
What went wrong? (add screenshot)
downloadManager marked as required
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Reading from the source code:
pdf.js/src/display/annotation_layer.js
Line 2846 in 57d196e
it appears to me it was not an intention to mark downloadManager as a required parameter in AnnotationLayerParameters:
pdf.js/src/display/annotation_layer.js
Line 63 in 57d196e
and AnnotationLayerBuilderOptions:
pdf.js/web/annotation_layer_builder.js
Line 40 in 57d196e
and it should be optional, similarly to accessibilityManager for example:
pdf.js/web/text_layer_builder.js
Line 30 in 57d196e
Configuration:
What is the expected behavior? (add screenshot)
downloadManager
to be optionalWhat went wrong? (add screenshot)
downloadManager
marked as requiredLink to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
The text was updated successfully, but these errors were encountered: