Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript modules in the legacy build #17258

Closed
benbro opened this issue Nov 11, 2023 · 3 comments
Closed

JavaScript modules in the legacy build #17258

benbro opened this issue Nov 11, 2023 · 3 comments

Comments

@benbro
Copy link
Contributor

benbro commented Nov 11, 2023

Is it possible to disable JavaScript modules in the legacy build?
According to this modules in workers are only supported in Firefox 114+ and Safari 15+ which means that we will have to stay on pdf.js v3.11.174 for the next few years.

@Snuffleupagus
Copy link
Collaborator

Is it possible to disable JavaScript modules in the legacy build?

No, since that'd add way too much maintenance/support burden; something that was mentioned in #17055 (comment).
(Please note that it's already a whole lot of work to keep the PDF.js library even running outside of the Firefox PDF Viewer, work that's nowadays only done by unpaid contributors such as myself and without anyone currently sponsoring that.)

According to this modules in workers are only supported in Firefox 114+ and Safari 15+

Please refer to the FAQ for the list of supported browsers: https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support
Of particular note here is that we didn't make any changes to this list in PDF.js version 4.0, hence the browsers you mention were already required in PDF.js version 3.11.174.

@Snuffleupagus Snuffleupagus closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2023
@benbro
Copy link
Contributor Author

benbro commented Nov 11, 2023

There is Module Workers Polyfill (source). Is it reasonable to include it with the pdf.js legacy build? This might extend the legacy build support to Firefox 100 and Safari 13.

@benbro
Copy link
Contributor Author

benbro commented Nov 12, 2023

I'm also getting "top-level await" warning when trying to compile pdf.js in an angular project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants