Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The viewer should be focused once the sidebar is closed #17361

Closed
calixteman opened this issue Dec 1, 2023 · 2 comments · Fixed by #17386
Closed

The viewer should be focused once the sidebar is closed #17361

calixteman opened this issue Dec 1, 2023 · 2 comments · Fixed by #17386
Labels
viewer

Comments

@calixteman
Copy link
Contributor

Configuration:

  • Web browser and its version: Firefox nightly
  • Operating system and its version: Windows 11

Steps to reproduce the problem:

  1. Open a pdf and the sidebar
  2. Click on a thumbnail
  3. Press SPACE to scroll down
  4. Close the sidebar
  5. Press SPACE to scroll

What is the expected behavior? (add screenshot)

The last scroll should scroll the document.

What went wrong? (add screenshot)

The last scroll isn't happening but the sidebar is reopen because the sidebar button is focused.
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Dec 6, 2023 •
edited
Loading

Should this be done unconditionally, i.e. even if the sidebarToggle-button is accessed via the keyboard, or only when it's clicked?

@calixteman
Copy link
Contributor Author

Only when the sidebar toggle button is clicked.

@Snuffleupagus Snuffleupagus linked a pull request Dec 6, 2023 that will close this issue
Remove focus from the toggleButton when closing the sidebar with a mouse (issue 17361) #17386
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
3 participants
@timvandermeij @Snuffleupagus @calixteman