Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web/app.js] Remove the remaining zoomDisabledTimeout usage? #17727

Closed
Snuffleupagus opened this issue Feb 26, 2024 · 1 comment · Fixed by #18423
Closed

[web/app.js] Remove the remaining zoomDisabledTimeout usage? #17727

Snuffleupagus opened this issue Feb 26, 2024 · 1 comment · Fixed by #18423

Comments

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Feb 26, 2024

With the primary use-case for the zoomDisabledTimeout functionality being removed in PR #17724, I wonder if we could get rid of the rest of this code now?
The remaining code was added in PR #10351 to work-around bug 1503412, but without access to a Mac I cannot tell if we still need that and if so whether it's possible to refactor it to remove the setTimeout-based hack?

/cc @calixteman The following patch simply removes the affected code, would you be able to test it on Mac?
master...Snuffleupagus:pdf.js:rm-setZoomDisabledTimeout

@Snuffleupagus Snuffleupagus changed the title [web/app.js] Remove the remaing zoomDisabledTimeout usage? [web/app.js] Remove the remaining zoomDisabledTimeout usage? Feb 26, 2024
@calixteman
Copy link
Contributor

Unfortunately, the bug is still there.
This is a Firefox issue and I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1882168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants