Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support progression orders RPCL, CPRL, PCRL #5481

Closed
MaMazav opened this issue Nov 9, 2014 · 7 comments
Closed

Support progression orders RPCL, CPRL, PCRL #5481

MaMazav opened this issue Nov 9, 2014 · 7 comments

Comments

@MaMazav
Copy link
Contributor

MaMazav commented Nov 9, 2014

(The issue is for documentation only, I'm going to submit a pull request).

Currently the mentioned progression orders are not supported, it would be nice to support them.

Examples:
https://www.dropbox.com/s/h3f9pmtjc7no5th/cabs_1tile_rpcl.jp2?dl=0
https://www.dropbox.com/s/0a9js1fbh63t9e9/cabs_1tile_pcrl.jp2?dl=0
https://www.dropbox.com/s/gmqdctj2dvh3mlm/cabs_1tile_cprl.jp2?dl=0

@MaMazav
Copy link
Contributor Author

MaMazav commented Nov 10, 2014

Changes have been done and committed in my repository.
The example images above work with that development and the changes in issue 5475 ('JPX: Out of packets' when there are more than one precinct per resolution levels).

I'm waiting for the pull request process to complete for the above issue (5479) in order to create a pull request for this issue.

@MaMazav
Copy link
Contributor Author

MaMazav commented Nov 15, 2014

Previous files are files with not interesting content - for example, single precinct in any resolution levels. Here are some more interesting test files - including multiple precincts per level and multiple quality layers:
https://www.dropbox.com/s/hel144qxpfeufmp/cabs_small_p128_cprl.jp2?dl=0
https://www.dropbox.com/s/7wmfce8d1fx0ab2/cabs_small_p128_pcrl.jp2?dl=0
https://www.dropbox.com/s/7purebj4ymjr697/cabs_small_p128_rpcl.jp2?dl=0

@MaMazav MaMazav closed this as completed Nov 15, 2014
@MaMazav MaMazav reopened this Nov 15, 2014
@CodingFabian
Copy link
Contributor

we merged da5c0cf so you might want to make a pr?

@MaMazav
Copy link
Contributor Author

MaMazav commented Nov 15, 2014

Great. I'll do it in the following days. I'm new to git (and having some other things to do :) ) so it will take some time until I understand how to do it correctly.

@Snuffleupagus
Copy link
Collaborator

I'm new to git (and having some other things to do :) ) so it will take some time until I understand how to do it correctly.

I would recommend that you follow the instructions provided in https://github.com/mozilla/pdf.js/wiki/Contributing.

@MaMazav
Copy link
Contributor Author

MaMazav commented Nov 18, 2014

I didn't succeed to run testing.

Meanwhile, to not delay the contribution even more, here is a PR:
#5494

If I have news about testing I'll update.

@timvandermeij
Copy link
Contributor

Fixed by #5494.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants