Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No visual indicator when a find toolbar checkbox or zoom dropdown are focused in Chrome #6211

Closed
Thunderforge opened this issue Jul 14, 2015 · 4 comments

Comments

@Thunderforge
Copy link
Contributor

When using Chrome, there is no visual indicator when you tab over to the "Highlight All" and "Match Case" checkboxes within the find toolbar.

Steps to reproduce:

  1. Open Chrome
  2. Go to the PDF.js demo PDF viewer
  3. Click on the Find button
  4. Use the tab keys to navigate over to either the "Highlight All" checkbox, the "Match Case" checkbox, or the zoom dropdown
  5. Note that there is no visual indicator that any of these elements are focused

In Firefox and Internet Explorer 11, the user can clearly see that these elements are focused because the label has a highlight around it. Note that the element is still able to be activated by using the spacebar (there is a separate issue regarding this behavior not working in Firefox or Internet Explorer 11), but there is no visual focus to indicate that the element has focus.

@Thunderforge Thunderforge changed the title No visual indicator when a find toolbar checkbox is focused in Chrome No visual indicator when a find toolbar checkbox or zoom dropdown are focused in Chrome Jul 15, 2015
@timvandermeij
Copy link
Contributor

Is this not an upstream browser issue then, if only Chrome has the problem, or do you think that this can somehow be caused by the PDF.js codebase?

@Thunderforge
Copy link
Contributor Author

The issue seems to be an issue with viewer.css. When you look at a CSS-less dropdown menu or checkbox, there is highlighting in Chrome. In fact, if you comment out the line to import the viewer.css, you can see a visual indicator when you focus those elements.

@slimjim181
Copy link

@Thunderforge is correct that it is an issue with viewer.css
However this issue of no focus states is present in more than just chrome as I have reproduced in:
Safari (9.1.1 11601.6.17)
Edge (25.10586.0.0)
IE11 (11.420.10586.0)
FF Win (47.0) - does have a 1px outline focus but is not as visible as FF Mac blue glow
FF 47.0 (Ubuntu 16.04)
Note these are all the latest versions of the browsers as of 22 Jun 2016 NZST

@Snuffleupagus
Copy link
Collaborator

This should have been (indirectly) fixed by the re-styling in PR #11077.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants