Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfjs-dist repository does not contain every file generated by 'gulp generic' #7203

Closed
keabard opened this issue Apr 15, 2016 · 2 comments
Closed

Comments

@keabard
Copy link

keabard commented Apr 15, 2016

In pdfjs-dist repository (https://github.com/mozilla/pdfjs-dist), there are many files missing:

  • viewer.html
  • viewer.js
  • l10n.js
  • debugger.js
  • locale files
  • etc...

The resulting repository is therefore unusable, even with a custom viewer.html.

Is there something missing in make.js or am I totally missing the point ?

The guy from PDFObject uses viewer.html from pdf.js repository, along with other missing files, to build his example with pdf.js fallback (http://pdfobject.com/examples/pdfjs.html).

How can I do the same without the missing files ?

@yurydelendik
Copy link
Contributor

We are not redistributing viewer.html to avoid (visual?) confusion of third party deployments with Firefox and Chrome extensions UI, as well as our demo viewer. There is no easy way to customize viewer.html/viewer.js, so it's not in a library yet. However there is set of components that will let you build customized viewer, see pdfjs-dist/web/pdf_viewer.js file and examples at https://github.com/mozilla/pdf.js/tree/master/examples/components. Once we will confident that our viewer can be easy customized (we are slowing working towards that) and not mistaken for the extensions, we will may include the listed files in some form. Closing as answered.

@yurydelendik
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants