-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the gulp extension
build target
#9768
Labels
Comments
And apparently I should have looked through Lines 1092 to 1093 in 5053d02
Please note: Ever since PR #8315, where support for outputting a packed Chromium extension was removed, those lines (in addition to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After PR #9566, the
gulp extension
build target is now basically just an alias forgulp chromium
; seepdf.js/gulpfile.js
Line 416 in e39541a
Hence it seems, at least to me, that the
gulp extension
build target could simply be removed now.Note that it's currently used at one other spot in
gulpfile.js
, seepdf.js/gulpfile.js
Line 911 in e39541a
That line can actually be simplified to just
gulp.task('web-pre', ['generic', 'jsdoc']);
, since the Chromium extension isn't included in thegh-pages
branch and building it is thus a waste of time/resources in that case.The text was updated successfully, but these errors were encountered: