Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the gulp extension build target #9768

Closed
Snuffleupagus opened this issue Jun 1, 2018 · 1 comment
Closed

Remove the gulp extension build target #9768

Snuffleupagus opened this issue Jun 1, 2018 · 1 comment
Labels

Comments

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Jun 1, 2018

After PR #9566, the gulp extension build target is now basically just an alias for gulp chromium; see

gulp.task('extension', ['chromium']);

Hence it seems, at least to me, that the gulp extension build target could simply be removed now.


Note that it's currently used at one other spot in gulpfile.js, see

gulp.task('web-pre', ['generic', 'extension', 'jsdoc']);

That line can actually be simplified to just gulp.task('web-pre', ['generic', 'jsdoc']);, since the Chromium extension isn't included in the gh-pages branch and building it is thus a waste of time/resources in that case.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Jun 4, 2018

And apparently I should have looked through gulpfile.js a bit closer before opening the issue, since these lines can be removed as well:

pdf.js/gulpfile.js

Lines 1092 to 1093 in 5053d02

gulp.src(CHROME_BUILD_DIR + '*.crx')
.pipe(gulp.dest(GH_PAGES_DIR + EXTENSION_SRC_DIR + 'chromium/')),

Please note: Ever since PR #8315, where support for outputting a packed Chromium extension was removed, those lines (in addition to the gulp web-pre task mentioned above) have been unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants