Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Comments

@stof
Copy link
Contributor

stof commented Nov 22, 2018

Currently, the ie_ref must be the name in the Edge JSON file. But there are often mistakes being done, using the page slug instead, as it is much eaiser to locate (the slug is part of the URL when looking it up in the Edge status website).

See #559 for the latest occurrence of such a fix.
Since I started contributing here, most of my PRs are about fixing such mistakes: https://github.com/mozilla/platform-status/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Astof

The slug can be generated based on the name (and the logic already exists in the codebase to generate the Edge link btw). So it might be great to support both the name and the slug as the reference for the update process (during the matching, the comparison would be done against the name, and also against a slug generated from the name). What do you think ?

@chrisdavidmills
Copy link
Contributor

This sounds like a good idea. I don't think I've ever got this right; it is very confusing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.