Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync tests rely on revision from pontoon/.git, and don't have access to it #2189

Closed
bugzilla-to-github opened this issue Oct 28, 2019 · 0 comments · Fixed by #3312
Closed
Labels
P3 Default, possibly shipping in the following two quarters sync task

Comments

@bugzilla-to-github
Copy link
Collaborator

This issue was created automatically by a script.

Bug 1591995

Bug Reporter: @Pike
CC: @mathjazz

When testing in the docker test environment, git doesn't have access to /app/.git, because it's on a different file system.

That means that some code paths (like writing revisions to the db) aren't tested at all. Perhaps also not at all for hg?

Also, the comment in docker-compose.yml about what depends on .git isn't correct.

This can be hacked around by adding

+            env={'GIT_DISCOVERY_ACROSS_FILESYSTEM':'1'}

in GitRepository.revision, but that's so not safe for prod.

@mathjazz mathjazz changed the title [docker] sync tests rely on revision from pontoon/.git, and don't have access to it Sync tests rely on revision from pontoon/.git, and don't have access to it Nov 6, 2021
@mathjazz mathjazz added the sync label Nov 10, 2021
@eemeli eemeli mentioned this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Default, possibly shipping in the following two quarters sync task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants