Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gift modal appears in reader mode output for lemonde.fr articles #919

Open
gijsk opened this issue Oct 29, 2024 · 0 comments
Open

Gift modal appears in reader mode output for lemonde.fr articles #919

gijsk opened this issue Oct 29, 2024 · 0 comments

Comments

@gijsk
Copy link
Contributor

gijsk commented Oct 29, 2024

Via https://bugzilla.mozilla.org/show_bug.cgi?id=1922931 .

HTML of the modal looks like this:

<div id="js-modal-gifted-url" class="article__gift-modal"> <div class="article__gift-modal__overlay"></div> <div class="article__gift-modal__content"> <div class="article__gift-modal__title"><span class="article__gift-modal__logo icon__gift"></span>Cet article vous est offert</div> <div class="article__gift-modal__text">Pour lire gratuitement cet article réservé aux abonnés, connectez-vous</div> <a class="lmd-btn lmd-btn--primary lmd-btn--l lmd-btn--fullwidth js_modal_login" href="https://secure.lemonde.fr/sfuser/connexion?gift=true">Se connecter</a> <div class="article__gift-modal__text article__gift-modal__text--no-margin lmd-typo--text-center"> Vous n'êtes pas inscrit sur Le Monde ? <br> <a class="article__gift-modal__link js_modal_login" href="https://secure.lemonde.fr/sfuser/register?gift=true">Inscrivez-vous gratuitement</a> </div> </div> </div>

The article__gift-modal class gets display: none in some CSS but that does not make it into readability's determinations of what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant