Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re:dash should support comments on queries #279

Open
fbertsch opened this issue Nov 4, 2017 · 3 comments
Open

re:dash should support comments on queries #279

fbertsch opened this issue Nov 4, 2017 · 3 comments

Comments

@fbertsch
Copy link

fbertsch commented Nov 4, 2017

Recently I was reviewing a very hefty query in a Databricks notebook, and was able to go through and highlight specific pieces and leave comments about those parts of the query. I think this would go a long way to making query writing, and data@moz, more reproducible and correct.

Related: getredash#4

@arikfr
Copy link

arikfr commented Nov 4, 2017

I assume you mean comments like you can comment on a Google Docs document? Marking specific areas and commenting on them?

@fbertsch
Copy link
Author

fbertsch commented Nov 4, 2017

@arikfr right, with support for responses and checking them off as resolved. I would say the Github reviews are probably a more similar feature set.

@arikfr
Copy link

arikfr commented Nov 4, 2017

👍

I wonder if it makes sense to integrate with GitHub, to offload the collaboration here and preserve familiar workflows (pull requests).

@rafrombrc rafrombrc added this to the 13 milestone Nov 29, 2017
@rafrombrc rafrombrc modified the milestones: 13, 15 Feb 21, 2018
@rafrombrc rafrombrc modified the milestones: 15, 16 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants