Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate porting "Use saved values for parameters in scheduled queries" #461

Closed
jezdez opened this issue Jul 13, 2018 · 2 comments
Closed

Investigate porting "Use saved values for parameters in scheduled queries" #461

jezdez opened this issue Jul 13, 2018 · 2 comments
Assignees
@alison985
Labels
merge upstream remove from fork

Comments

@jezdez
Copy link

jezdez commented Jul 13, 2018

Refs #43 (a7b4f46)

Investigate only since it seems as if the commit related to that issue only contains a test and the issue doesn't clearly state that this was an existing feature that just wasn't clear how to use.

Ironically getredash#2644 is working on this right now so it'd e splendid if we could donate that test (if it makes sense) to that.
@alison985 alison985 mentioned this issue Sep 10, 2018
Merged
@alison985
Copy link

Adding test passes in the upstream master branch from ~10 days ago, so I went ahead and made a PR to add it to upstream. getredash#2802

@alison985 alison985 added in review in review upstream PR in review in getredash/redash labels Sep 10, 2018
@alison985 alison985 self-assigned this Sep 10, 2018
@alison985 alison985 added merge upstream and removed in review in review upstream PR in review in getredash/redash labels Sep 16, 2018
@jezdez
Copy link
Author

jezdez commented Sep 17, 2018

Huzzah! Merged in upstream 👍

@jezdez jezdez closed this as completed Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alison985 alison985

Labels
merge upstream remove from fork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jezdez @alison985