Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate porting hide query more menu if empty #554

Closed
jezdez opened this issue Sep 14, 2018 · 1 comment
Closed

Investigate porting hide query more menu if empty #554

jezdez opened this issue Sep 14, 2018 · 1 comment
Assignees
Milestone

Comments

@jezdez
Copy link

jezdez commented Sep 14, 2018

#208, PR: #209

We need to check if this is applicable to upstream since there may be other modifications to the menu in our fork requiring it.

@alison985
Copy link

This is no longer a necessary diff between upstream and our fork because the UI has changed. In upstream master this menu is no longer displayed at all before save - which is what this change does.

There is a difference in the menus - on our fork there is an extra option to "Manage Permissions" but it only displays after a query is saved so it has no application to this use case.

Closing ticket.

@jezdez jezdez added this to the 17 milestone Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants