Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop compiling LLVM with asserts #3615

Closed
brson opened this issue Sep 28, 2012 · 5 comments
Closed

Stop compiling LLVM with asserts #3615

brson opened this issue Sep 28, 2012 · 5 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. I-compiletime Issue: Problems and improvements with respect to compile times.

Comments

@brson
Copy link
Contributor

brson commented Sep 28, 2012

LLVM has a lot of asserts, and we build them. In a hypothetical Rust production build maybe we want to not do that.

It's at least worth investigating the perf impact.
@bblum
Copy link
Contributor

bblum commented Jun 21, 2013

I ran a fresh build of all stages (on 45f588e) in both ways. With assertions turned on it took 20m46s, and with them disabled it took 17m40s (== 85%).

@bblum bblum mentioned this issue Jul 13, 2013
Closed
@metajack
Copy link
Contributor

I think this ended up in production ready during the initial sweep. Nominating to remove milestone. This doesn't seem related to maturity.

@pnkfelix
Copy link
Member

agreed to demilestone

@steveklabnik
Copy link
Member

Triage: we still build with assertions, but we have a flag to build without.

@steveklabnik
Copy link
Member

6b95d8b

This makes the default configuration fully optimized, with ... no llvm asserts,

RalfJung pushed a commit to RalfJung/rust that referenced this issue May 19, 2024
@bors
Auto merge of rust-lang#3615 - RalfJung:rustup, r=RalfJung
8d7c8ac 
Rustup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. I-compiletime Issue: Problems and improvements with respect to compile times.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @metajack @brson @pnkfelix @bblum