Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustpkg should support semantic versions #8405

Closed
catamorphism opened this issue Aug 8, 2013 · 3 comments
Closed

rustpkg should support semantic versions #8405

catamorphism opened this issue Aug 8, 2013 · 3 comments

Comments

@catamorphism
Copy link
Contributor

Metabug: #5677

There's already a SemVer variant in the Version datatype, but I've completely ignored it so far. There are no tests for it. This should change.
@ghost ghost assigned catamorphism Aug 8, 2013
@graydon graydon mentioned this issue Aug 14, 2013
Closed
@huonw
Copy link
Member

huonw commented Dec 19, 2013

Triage: no change, and git grep implies that the SemanticVersion type is never constructed in rustpkg.

@klutzy
Copy link
Contributor

klutzy commented Jan 8, 2014

cc #11396. I think this would work well only if all libraries use semver.

@klutzy klutzy mentioned this issue Jan 11, 2014
Merged
bors added a commit that referenced this issue Jan 22, 2014
@bors
auto merge of #11478 : klutzy/rust/rustpkg-crate-id, r=cmr
c6adb91 
This patchset consists of three parts:

- rustpkg doesn't guess crate version if it is not given by user.
- `rustpkg::version::Version` is replaced by `Option<~str>`.
  It removes some semantic versioning portions which is not currently used.
  (cc #8405 and #11396)
  `rustpkg::crate_id::CrateId` is also replaced by `syntax::crateid::CrateId`.
- rustpkg now computes hash to find crate, instead of manual filename parse.

cc @metajack
bors added a commit that referenced this issue Jan 24, 2014
@bors
auto merge of #11478 : klutzy/rust/rustpkg-crate-id, r=cmr
2b62371 
This patchset consists of three parts:

- rustpkg doesn't guess crate version if it is not given by user.
- `rustpkg::version::Version` is replaced by `Option<~str>`.
  It removes some semantic versioning portions which is not currently used.
  (cc #8405 and #11396)
  `rustpkg::crate_id::CrateId` is also replaced by `syntax::crateid::CrateId`.
- rustpkg now computes hash to find crate, instead of manual filename parse.

cc @metajack
@sinistersnare
Copy link
Contributor

rustpkg is dead, should we close this?

@catamorphism catamorphism removed their assignment Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@catamorphism @huonw @thestinger @klutzy @sinistersnare