Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustpkg makes it difficult to work with local changes to submodules #9514

Closed
catamorphism opened this issue Sep 26, 2013 · 3 comments
Closed

Comments

@catamorphism
Copy link
Contributor

Currently, there is no easy way when using rustpkg to write:

extern mod foo = "github.com/mozilla/whatever";

and concurrently be developing the whatever package, with local patches that aren't in the github repo. You can make local changes, but rustpkg will overwrite them (although you shouldn't be able to, as per #6480). If you instead check out the sources for whatever into a different directory and work on the copy in that directory, you have to change the extern mod directive and, for the benefit of anyone else using your package, bundle the sources for whatever as a submodule. This is not ideal. I'm not sure how to reconcile wanting to name packages by their URLs with wanting to make local changes to them.

/cc @metajack since we talked about this before.

@catamorphism
Copy link
Contributor Author

I think this needs to be fixed in concert with #6480 , otherwise there's too much potential for confusion in the meantime.

@catamorphism
Copy link
Contributor Author

This can close when #9732 lands. See the tests::test_installed_local_changes for how it's supposed to work.

@catamorphism
Copy link
Contributor Author

#9732 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant