Remove io::io_error #10449
Remove io::io_error #10449
Conversation
|
It might be sensible to implement Drop on either Result, IoError or a variant of Result that calls fail! in the error case, and a language change so that destructuring it is possible and skips dropping. This way, errors would continue to be fatal by default. Regarding ByteIterator, why not just store the result of the last operation (i.e. the one that returned EOF or another error) and adding a "finish" method that would take the ByteIterator by value and get the contained IoError? Maybe one could even extend foreach so that the value of the foreach statement is the return value of the finish method (provided the iterator implements the appropriate trait), but not sure about this. |
|
I was thinking of how to do something like that, but I couldn't really come up with a convenient structure which behaved like that. I'd love to have one, but I don't seem to be able to come up with an implementation :( |
|
I assume making I/O errors |
This commit removes all usage of conditions from the runtime and I/O implementation. The new idea is to return IoResult which is a typedef on Result<T, IoError>. The error portion of this may wish to change in the future, but for now it's a good step forward to remove conditions. Some notable changes: * the if_ok!/seq! macros * Removed ByteIterator * The fmt traits must now return IoResult<()> * All I/O errors in json encoding/decode are now ignored * All I/O errors in rustdoc are now ignored * The signature of print/println has changed * The signature of read_bytes() has changed
|
This isn't making as much progress as I would like, and I believe that this requires more thought than I'm giving it. Closing for now. |
…tr-casts-parens, r=Jarcho Wrap `transmutes_expressible_as_ptr_casts` suggestions in parentheses changelog: [`transmutes_expressible_as_ptr_casts`]: Fix suggestion missing wrapping parentheses Fixes rust-lang#10449 r? `@Jarcho` Is this the best way to go about this? `unused_parens` will catch the unnecessary ones but emitting them in the first place isn't ideal
This commit removes all usage of conditions from the runtime and I/O
implementation. The new idea is to return IoResult which is a typedef on
Result<T, IoError>. The error portion of this may wish to change in the future,
but for now it's a good step forward to remove conditions.
Some notable changes:
if_ok!/seq!macros -- right now these are only defined in libstd, but they're definitely in the wrong spot and may belong in the core-macro injection as well.This is not quite ready for merging just yet. I'd like to get some feedback on this before cleaning this up for a true merge. I don't like how errors are default not-fatal any more, but the code isn't really that much less readable in my opinion. There's also not a lot of heavy I/O code except for rustdoc which just ignores all errors, so this perhaps isn't the best showcase of conversion.
I'm mainly soliciting for feedback about this. I think that this is the right way to go in general (moving away from conditions), but if there are any reservations about the specifics we should probably discuss them now.