Shink NodeId, CrateNum, Name and Mrk down to 32 bits on x64. #10670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍, but this should be discussed (even if briefly) at the meeting I think. |
|
I'll make sure its on the agenda. |
| @@ -285,7 +285,7 @@ fn resolve_crate(e: @mut Env, | |||
| // Claim this crate number and cache it | |||
| let cnum = e.next_crate_num; | |||
| e.crate_cache.push(cache_entry { | |||
| cnum: cnum, | |||
| cnum: cnum as int, | |||
There was a problem hiding this comment.
Why is this cast necessary, shouldn't cache_entry.cnum be type CrateNum?
bors
added a commit
that referenced
this pull request
Nov 27, 2013
### Rationale There is no reason to support more than 2³² nodes or names at this moment, as compiling something that big (even without considering the quadratic space usage of some analysis passes) would take at least **64GB**. Meanwhile, some can't (or barely can) compile rustc because it requires almost **1.5GB**. ### Potential problems Can someone confirm this doesn't affect metadata (de)serialization? I can't tell myself, I know nothing about it. ### Results Some structures have a size reduction of 25% to 50%: [before](https://gist.github.com/luqmana/3a82a51fa9c86d9191fa) - [after](https://gist.github.com/eddyb/5a75f8973d3d8018afd3). Sadly, there isn't a massive change in the memory used for compiling stage2 librustc (it doesn't go over **1.4GB** as [before](http://huonw.github.io/isrustfastyet/mem/), but I can barely see the difference). However, my own testcase (previously peaking at **1.6GB** in typeck) shows a reduction of **200**-**400MB**.
bors
added a commit
that referenced
this pull request
Dec 1, 2013
**Note**: I only tested on top of my #10670 PR, size reductions come from both change sets. With this, [more enums are shrinked](https://gist.github.com/eddyb/08fef0dfc6ff54e890bc), the most significant one being `ast_node`, from 104 bytes (master) to 96 (#10670) and now to 32 bytes. My own testcase requires **200MB** less when compiling (not including the other **200MB** gained in #10670), and rustc-stage2 is down by about **130MB**. I believe there is more to gain by fiddling with the enums' layouts.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 5, 2023
Don't suggest `suboptimal_flops` unavailable in nostd Fixes rust-lang#10634 changelog: Enhancement: [`suboptimal_flops`]: Do not suggest `{f32,f64}::abs()` or `{f32,f64}::mul_add()` in a `no_std`-environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
There is no reason to support more than 2³² nodes or names at this moment, as compiling something that big (even without considering the quadratic space usage of some analysis passes) would take at least 64GB.
Meanwhile, some can't (or barely can) compile rustc because it requires almost 1.5GB.
Potential problems
Can someone confirm this doesn't affect metadata (de)serialization? I can't tell myself, I know nothing about it.
Results
Some structures have a size reduction of 25% to 50%: before - after.
Sadly, there isn't a massive change in the memory used for compiling stage2 librustc (it doesn't go over 1.4GB as before, but I can barely see the difference).
However, my own testcase (previously peaking at 1.6GB in typeck) shows a reduction of 200-400MB.