Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from winapi to windows-rs #2185

Closed
ognevny opened this issue May 25, 2024 · 6 comments · Fixed by #2233
Closed

migrate from winapi to windows-rs #2185

ognevny opened this issue May 25, 2024 · 6 comments · Fixed by #2233

Comments

@ognevny
Copy link
Contributor

ognevny commented May 25, 2024

motivation

winapi hasn't been updated for more than 3 years and the maintainer said that they have no motivation to continue the development of it. for now the recommended approach is to use windows-rs, which also has support for *-gnullvm windows targets

@Xuanwo
Copy link
Collaborator

Xuanwo commented May 25, 2024

Makes sense, would you like to submit a PR for this? I'm willing to help review and get it's merged.

@ognevny
Copy link
Contributor Author

ognevny commented May 25, 2024

Makes sense, would you like to submit a PR for this? I'm willing to help review and get it's merged.

I can try to do this

@ognevny
Copy link
Contributor Author

ognevny commented May 25, 2024

I have some work implemented: https://github.com/ognevny/sccache/tree/migrate-from-winapi. but there are lots of errors as some API is needed to be adjusted. currently I have no idea what to do with them

@Xuanwo
Copy link
Collaborator

Xuanwo commented Jul 25, 2024

I will take a look, thanks!

@ognevny
Copy link
Contributor Author

ognevny commented Jul 25, 2024

I will take a look, thanks!

I still didn't make any change with that branch... migration from winapi requires for some code "remake" since bindings from microsoft work in a bit another way

@Xuanwo
Copy link
Collaborator

Xuanwo commented Jul 25, 2024

I failed to implement it because I know very little about Windows. However, my friend @Berrysoft, who is an expert in Windows, is interested in this issue and is currently working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants