Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

When you upload/download a large file, there is a noticeable delay until the progress bar is displayed #128

Closed
SoftVision-CosminMuntean opened this issue Jun 23, 2017 · 7 comments · Fixed by #285
Assignees

Comments

@SoftVision-CosminMuntean
Copy link

SoftVision-CosminMuntean commented Jun 23, 2017

[Affected versions]:

  • Firefox 54.0 and up

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Steps to reproduce]:

  1. Start the Firefox browser with and navigate to "https://send.dev.mozaws.net" page.
  2. Upload a large file (eg: 1.0 Gb) and observe the behavior.

[Expected result]:

  • The progress bar is displayed even if the upload didn't start.
    Or
  • A loading spinner appears until the progress bar is displayed.

[Actual results]:

  • There is a noticeable delay (depends on how large is the file) until the progress bar is displayed.

[Notes]:

  • The user probably think that the download/upload is not working.
  • The issue is also reproducible when downloading a large file.
  • This issue is also reproducible on the stage page (https://send.stage.mozaws.net).
  • Here is a screen recording with the issue:
    delay until progres bar
@ghost
Copy link

ghost commented Jun 23, 2017

We can fix this when we have the new designs. @sevaan let's connect at the all hands to talk about this

@ghost ghost added this to the Dedicated Dingo milestone Jun 23, 2017
@dannycoates
Copy link
Contributor

There's a few discrete steps that happen before the upload begins. Each can take a noticeable amount of time for large files.

  1. Loading the file from disk into Firefox
  2. Hashing the file (not in master yet)
  3. Encrypting the file

We know when each of these steps starts and ends, but we can't get progress on any of them.

@ekr
Copy link

ekr commented Jun 24, 2017 via email

@pdehaan pdehaan mentioned this issue Jun 26, 2017
@dannycoates
Copy link
Contributor

You could probably stream all of these.... Is that something you want to
look at?

Yes. We'll be working on this in v2.

@abhinadduri in the meantime lets emit an event for each phase in fileSender and fileReceiver so the ui can show a label.

@abhinadduri
Copy link
Collaborator

@dannycoates Do you want to emit separate events for hashing and encrypting? Right now both of those are in the same "Promise.all" so adding in code to emit separately for those two phases would need some refactoring.

@dannycoates
Copy link
Contributor

@abhinadduri a single event for both is fine

@SoftVision-CiprianMuresan

The issue is no longer reproducible on the Dev page. There no longer is any delay until the progress bar appears 🎉 .
Marking as verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants