Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Uploading a large file has a huge impact on memory #176

Closed
SoftVision-CiprianMuresan opened this issue Jul 10, 2017 · 5 comments
Closed

Comments

@SoftVision-CiprianMuresan

[Affected versions]:

  • Nightly 56

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Steps to reproduce]:

  1. Start the Firefox browser and navigate to "https://send.dev.mozaws.net/" page.
  2. Upload a large file and open the Task Manager.
  3. Sort by Memory and observe the Nightly process.

[Expected result]:

  • Low to moderate memory impact.

[Actual results]:

  • Memory usage is ~2GB.

[Notes]:

@ghost
Copy link

ghost commented Jul 10, 2017

With the way we are processing files this is expected behavior. We are considering looking into chunking/streaming in v2

@ghost ghost closed this as completed Jul 10, 2017
@pdehaan
Copy link
Collaborator

pdehaan commented Jul 10, 2017

@SoftVision-CiprianMuresan Do you remember how "large" the large file was? 100MB? 1GB?

@SoftVision-PaulOiegas
Copy link

@pdehaan almost 2GB. You can see that in the screen recording.

@pdehaan
Copy link
Collaborator

pdehaan commented Jul 10, 2017

Also see #170 (comment), which has an excellent breakdown of different browser behaviors when trying to upload 1-2GB files.

I'll argue that since the behavior leans more towards crashing in certain browsers, we should at least put some note in the UI that sending files over X megabytes may not work as expected, depending on browsers.

Also, maybe we should start an FAQ.md file where we answer some [soon to be] commonly asked questions.

@SoftVision-PaulOiegas
Copy link

Agree on that, users should be notified about the behavior/risk.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants