Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Show file size limit in UI #50

Closed
dannycoates opened this issue Jun 7, 2017 · 2 comments
Closed

Show file size limit in UI #50

dannycoates opened this issue Jun 7, 2017 · 2 comments
Assignees
@dnarcese
Milestone
Dedicated Dingo

Comments

@dannycoates
Copy link
Contributor

If a user chooses a file with a size > 2GB the upload currently silently fails. We should check the file size before loading it with the FileReader and tell the user the file is too big.
@dannycoates dannycoates added this to the Bubblicious Bluebird milestone Jun 7, 2017
@dnarcese dnarcese self-assigned this Jun 8, 2017
@dannycoates
Copy link
Contributor Author

In light of #95 we should be able to have different limits based on the browser. We could base this off of navigator.userAgent. Does anyone have a better option to key off of?

@ghost ghost modified the milestones: Calico Cat, Dedicated Dingo Jul 5, 2017
@dnarcese
Copy link
Collaborator

dnarcese commented Jul 6, 2017

#168 makes sure the upload doesn't silently fail and shows a generic error message...
specific size limit errors to come

@dnarcese dnarcese mentioned this issue Jul 19, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dnarcese dnarcese

Labels
None yet
Projects
None yet
Milestone
Dedicated Dingo
Development

No branches or pull requests
2 participants
@dannycoates @dnarcese