-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing whatwg-url polyfill #400
Labels
feat
New feature
Comments
They mention here why Lines 9 to 20 in 02f3d6b
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi all. We're considering adopting source-map in a project that will be used in browsers, and this chart is giving us pause:
This stark difference is entirely accounted for by the addition of whatwg-url as a dependency. It doesn't affect Node at all (which either uses the built in
URL
object orrequire("url").URL
as appropriate), so this polyfill is for the benefit of browsers that don't supportURL
, which is basically just IE and Opera Mini.If this package is intended to be used in browsers, I'd argue that keeping the bundle size small is a worthwhile goal. I see a couple of options:
I'd be happy to work on a pull request if you could give me some guidance. Thank you!
The text was updated successfully, but these errors were encountered: