-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forced Colors Mode #463
Comments
So to be clear this is about:
Regarding the general feature, I think we're generally supportive. As you said Gecko is already shipping and has shipped for a long time something like this, based on computed-value-time adjustments / I think my main concerns about the used-value time adjustments are:
Regarding the media queries, I think my main concern is w3c/csswg-drafts#5433. I think that that duplication is quite unfortunate, but I don't think we reached a conclusion at TPAC. Do you know what does Chromium plan to ship wrt the media queries? It'd be nice if we resolved on that issue before those media features get shipped on Chromium... |
I filed w3c/csswg-drafts#5779 on the above, and w3c/csswg-drafts#5778 on something else I noticed while thinking about that :) |
Thanks Emilio! I appreciate the feedback. Regarding your questions and concerns:
Yeah that's a good point, although user stylesheets could also use
@kbabbitt has been working on the implementation of system colors computing to themselves, so he can probably fill in some of the details that I miss here. However, it sounds like we are currently resolving the keywords eagerly during interpolation. Kevin is planning to open a CSSWG issue around this to clarify the expected behavior. In any event, we had implemented the move of forced colors to used-value time such that it wasn't dependent on the system colors computing to themselves feature shipping. We are currently storing both the keyword and resolved value for system colors to accomplish this at used-value time while the system color work is still underway.
As a part of shipping Forced Colors Mode, we are planning to ship the |
Correct, currently the code eagerly resolves system colors to used values for interpolation. I had tossed out the idea of using color-mix() for the interpolated value in w3c/csswg-drafts#5392 but I don't know that it actually got agreed to. I opened w3c/csswg-drafts#5780 to get this clarified. |
Request for Mozilla Position on an Emerging Web Specification
https://bugzilla.mozilla.org/show_bug.cgi?id=1659511
https://bugzilla.mozilla.org/show_bug.cgi?id=1663200
Other information
Given that a version of Forced Colors Mode has already shipped in Gecko, the main focus of this review is around the MQ and CSS aspects of the Forced Colors Mode feature.
The text was updated successfully, but these errors were encountered: