Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust number of histograms to number of keys #374

Open
leplatrem opened this issue Jan 17, 2018 · 3 comments
Open

Adjust number of histograms to number of keys #374

leplatrem opened this issue Jan 17, 2018 · 3 comments

Comments

@leplatrem
Copy link

For keyed histograms, there seems to be no way to control the number of displayed histograms (always 4).

If I explicitly set the ?keys= parameter with two values, the app fills the remaining 2 with some random key.

If I set four keys values using the __none__ keyword (as if I would have selected none in the key combobox), it is not taken into account.

Ideally, I wish the number histograms would respect the number of keys provided (and even go beyond four if that's reasonable).

I would be interested in contributing a patch if you could guide me through a little bit :)

Thanks !

@chutten
Copy link
Contributor

chutten commented Jan 17, 2018

The magic number 4 is baked into new-pipeline/src/dist.js in several places. It might be a not-insignificant amount of work to extricate the code from its grip.

You're welcome to try, and I'll help you as best I can... but it may be more productive if you told me what your use case was. I might be able to suggest a tool better suited to your needs.

@leplatrem
Copy link
Author

Thanks for your feedback!

Our usecase is simple: show the user the categorical histograms for 6-8 different keys. In our UI we could put a link to the telemetry dashboard for individual histograms in front of each key, or just have a single link somewhere on top that leads to a dashboard that contains all 6 of them.

Using the pointers you gave us in mozilla-extensions/remote-settings-devtools#15 I think we could directly embed the histograms in our UI instead of having external links. We'll explore that first :)

Feel free to close this issue if its priority is too low, I'll re-open it in the case we reach a dead-end with embedding...

@chutten
Copy link
Contributor

chutten commented Jan 18, 2018

We'll keep this open, but at a low priority. We're looking at TMO improvements this year, so we should keep this use case in mind while we design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants