Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce a minimum percentage of code coverage #104

Closed
kumar303 opened this issue Mar 3, 2016 · 3 comments
Closed

Enforce a minimum percentage of code coverage #104

kumar303 opened this issue Mar 3, 2016 · 3 comments

Comments

@kumar303
Copy link
Contributor

kumar303 commented Mar 3, 2016

We landed code coverage in #89 but it doesn't cause the tests to fail if a patches fails to achieve a set percentage of code coverage (correct me if I'm wrong). We should set something for this, maybe enforce 90% coverage?
@kumar303
Copy link
Contributor Author

kumar303 commented Mar 3, 2016

@rpl let me know what you think

@kumar303
Copy link
Contributor Author

kumar303 commented Mar 3, 2016

Oh, heh, I think it's already failing with improper coverage. Is that what I'm seeing here? https://coveralls.io/builds/5296203 What is the threshold set to?

@kumar303
Copy link
Contributor Author

kumar303 commented Mar 4, 2016

I see what's happening now! The build fails if you decrease the percentage of coverage and it passes if you do not. I like it 🍉 🌴

@kumar303 kumar303 closed this as completed Mar 4, 2016
@snyk-bot snyk-bot mentioned this issue Apr 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kumar303