Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firefox-profile-js dependency because of security warning #2026

Closed
wachunei opened this issue Sep 21, 2020 · 5 comments
Closed

Update firefox-profile-js dependency because of security warning #2026

wachunei opened this issue Sep 21, 2020 · 5 comments

Comments

@wachunei
Copy link

Is this a feature request or a bug?

Dependency request feature because of security warning
saadtazi/firefox-profile-js#112

What is the current behavior?

dependency firefox-profile-js version 2.0.0

What is the expected or desired behavior?

update to version 3.1.0

@rpl
Copy link
Member

rpl commented Sep 21, 2020

Note to self: firefox-profile@3.1.0 isn't officially released yet, but there is a firefox-profile@3.1.0-alpha.1 alpha version that has to be tested to provide feedback to the upstream firefox-profile developer (See saadtazi/firefox-profile-js#112 (comment)).

@wachunei
Copy link
Author

wachunei commented Sep 21, 2020

Hello @rpl, I've opened a Draft PR #2029 with the temporary update, so far all tests are passing, I'm going to report this to firefox-profile maintainer. I just want to ask you if your are certain the test suite is covering this package.

@wachunei
Copy link
Author

Handled by #2030

@Rob--W
Copy link
Member

Rob--W commented Sep 21, 2020

Note that firefox-profile-js only uses the zip functionality of archiver: https://github.com/saadtazi/firefox-profile-js/blob/cd63285ffa575637472ff281b0d671d3b36d606a/lib/firefox_profile.js#L455

The security vulnerability is in the tar-stream package, which is presumably used for tar files, not zip files. This security warning is not applicable to firefox-profile-js nor web-ext.

@Rob--W
Copy link
Member

Rob--W commented Oct 1, 2020

Fixed by #2030.

@Rob--W Rob--W closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants