TypeError: Cannot read property 'split' of undefined in Ubuntu

[Sharcoux]

Is this a feature request or a bug?

Bug

What is the current behavior?

In Ubuntu, run web-ext run -p <any profile>. It should fail.

What is the expected or desired behavior?

Should run

Version information (for bug reports)

• Firefox version: 115.0.1 (64 bits)
• Your OS and version: Ubuntu 22.04
• Paste the output of these commands:

node --version && npm --version && web-ext --version
v14.21.3
9.6.4

I opened an issue in firefox-profile-js this lib is depending upon that might be the culprit.

[Sharcoux]

According to firefox-profile author, the issue might be that web-ext doesn't manage correctly the this reference, maybe calling the class without the new keyword. I see some manipulations in the current code that, indeed, could end up losing this to some other object. I'm not comfortable enough with web-ext to help further, though.

[rpl]

Hi @Sharcoux thanks for investigating this issue, would you be able to attach the full error stack? (eventually passing --verbose to the web-ext command if without it the error stack is omitted).

Don't worry if you are unable to, we will try to reproduce it locally and get the full error stack so that we can dig deeper into this issue.

[Sharcoux]

Sure:

Running web extension from [...]
[...]/node_modules/firefox-profile/node_modules/ini/ini.js:67
  const lines = str.split(/[\r\n]+/g)
                    ^

TypeError: Cannot read property 'split' of undefined
    at Object.decode ([...]/node_modules/firefox-profile/node_modules/ini/ini.js:67:21)
    at ReadFileContext.callback ([...]/node_modules/firefox-profile/lib/profile_finder.js:57:24)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (fs.js:282:13)
error Command failed with exit code 1.

[Rob--W]

The error is in firefox-profile: https://github.com/saadtazi/firefox-profile-js/blob/932b40ea8758f22b938af653709767e50a26b98d/lib/profile_finder.js#L55-L57

When reading the file fails (e.g. due to it not existing), supposedly a callback should be called with the error. At line 56, the logic should not only invoke the callback with the error, but also return. Not returning results in the next line trying to parse non-existing content, which results in the error seen above.

[saadtazi]

The error is in firefox-profile: https://github.com/saadtazi/firefox-profile-js/blob/932b40ea8758f22b938af653709767e50a26b98d/lib/profile_finder.js#L55-L57

When reading the file fails (e.g. due to it not existing), supposedly a callback should be called with the error. At line 56, the logic should not only invoke the callback with the error, but also return. Not returning results in the next line trying to parse non-existing content, which results in the error seen above.

@Rob--W I just published firefox-profile v4.4.0 that fixes the issue above. I hope this helps.

[willdurand]

fixed by #2897

[Rob--W]

@Rob--W I just published firefox-profile v4.4.0 that fixes the issue above. I hope this helps.

Thanks for the update!