Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude web-ext-artifacts folder from web-ext build #291

Closed
callahad opened this issue Jun 15, 2016 · 4 comments · May be fixed by TheLOGOGuy/web-ext#33, aliceUnhinged613/web-ext#8, sirinartk/web-ext#12 or dongseok1985/web-ext#16

Comments

@callahad
Copy link

callahad commented Jun 15, 2016

When running:

web-ext build

The web-ext-artifacts directory can be completely ignored. Currently it is not ignored. You can see it included by checking the listing inside the .zip. Here is an example using beatify.

$ unzip -l web-ext-artifacts/beastify-1.0.zip
Archive:  web-ext-artifacts/beastify-1.0.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
        0  09-21-16 18:01   beasts/
        0  09-21-16 18:01   content_scripts/
        0  09-21-16 18:01   icons/
        0  09-21-16 18:01   popup/
        0  09-21-16 18:01   web-ext-artifacts/
        ...
@kumar303
Copy link
Contributor

I'm not sure if we have an issue for it but there is a patch in the works: #275

@kumar303
Copy link
Contributor

The contributor working on #275 told me he doesn't currently have time to complete the work so this bug is available for anyone else.

@kumar303
Copy link
Contributor

kumar303 commented Sep 21, 2016

Actually, this isn't such a good first bug because it involves making some architectural changes to FileFilter.

This isn't very high priority because the problematic files inside web-ext-artifacts (such as other XPI files) are already ignored.

@kumar303
Copy link
Contributor

oops, this was a dupe of #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment