feat: Support using a proxy to access the signing API #571
Conversation
| @@ -159,11 +159,6 @@ If you want to use scopes then it would look more like: | |||
| The commit message formatting described above is automatically enforced | |||
| each time you commit to your work branch to make continuous integration smoother. | |||
|
|
|||
| **If you're on Windows**, the commit message verification currently doesn't | |||
There was a problem hiding this comment.
These changes were merged to master in c0dc674 \o/ If you pull changes from master and push those changes to your fork of the repository then they won't appear in this pull request.
There was a problem hiding this comment.
Sorry about that fixing it!! 👍
| @@ -210,6 +210,11 @@ Example: $0 --help run. | |||
| demand: true, | |||
| type: 'string', | |||
| }, | |||
| 'api-proxy': { | |||
| describe: 'Use a proxy to access the signing API', | |||
There was a problem hiding this comment.
I would add another sentence to this: "Example: https://yourproxy:6000"
This will help people understand what kind of value they would need to pass to this option.
|
Made the requested changes but not sure why checks are failing, any pointers? Thank you! |
|
The test failure is because the code has trailing whitespace on line 214 of |
| @@ -210,6 +210,13 @@ Example: $0 --help run. | |||
| demand: true, | |||
| type: 'string', | |||
| }, | |||
| 'api-proxy': { | |||
| describe: | |||
There was a problem hiding this comment.
I think this is the line with some white space at the end of it. Try deleting everything after describe:.
There was a problem hiding this comment.
Ah, I turned off Eslint earlier today then forgot to turn it on, so didn't even notice the white space. All fixed now, thanks for your patience!
|
I'm sorry but I don't know what else to do, Travis CI keeps failing due to earlier upstream merge it seems, should I close this pr and open a new one I don't know. |
|
Everything looks great, thanks again! I'll merge it in. The last error in the test suite is because of a formatting problem with one of your older commits. It's a confusing error message though. Also, it's hard to fix because you need to rewrite the git history in your branch. Don't worry, I know it's not broken so you don't have to fix it :) I actually prevented this error from happening but I think you cloned the repo before I fixed it. When you get a chance, run |
Fixes #345
I started to work on this but not sure if I'm missing anything, so decided to make the pull request to see if it's working for everyone else like it's supposed to.