Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bot needinfo requests can override existing requests #610

Open
jgraham opened this issue Jan 7, 2020 · 1 comment
Open

bot needinfo requests can override existing requests #610

jgraham opened this issue Jan 7, 2020 · 1 comment

Comments

@jgraham
Copy link
Member

jgraham commented Jan 7, 2020

See https://bugzilla.mozilla.org/show_bug.cgi?id=1605610#c15
@jgraham
Copy link
Member Author

jgraham commented Jan 7, 2020

I think the code is assuming that we are updating a list of existing objects, but actually we're providing flag-change objects c.f. https://bmo.readthedocs.io/en/latest/api/core/v1/bug.html#update-bug So I think the logic should be we add the new flag if the user isn't already needinfo'd but don't if they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgraham