Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add separate Oculus 6DOF build target #1307

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Conversation

MortimerGoro
Copy link
Contributor

No description provided.

@MortimerGoro MortimerGoro requested a review from bluemarvin June 10, 2019 11:11
@bluemarvin
Copy link
Contributor

@MortimerGoro My expectation is that 3DoF will eventually cease to be supported. Would it make more sense to name the build targets oculusvr3Dof for the Go and oculusvr for the Quest and all future 6Dof devices?

@MortimerGoro MortimerGoro force-pushed the oculus_6dof_manifest branch from 043cd34 to 7c3ad15 Compare June 10, 2019 16:31
@MortimerGoro MortimerGoro force-pushed the oculus_6dof_manifest branch from 7c3ad15 to 04930be Compare June 10, 2019 16:55
@MortimerGoro
Copy link
Contributor Author

@bluemarvin it makes sense. PR already updated

@bluemarvin
Copy link
Contributor

bluemarvin commented Jun 10, 2019

Hm, for some reason oculusvrArm64 isn't building. I'll look into the script.

Okay, it does work, I was looking in the wrong place. Validating symbol upload script now.

@bluemarvin bluemarvin merged commit d3621e2 into master Jun 10, 2019
@philip-lamb philip-lamb deleted the oculus_6dof_manifest branch June 11, 2019 00:26
@philip-lamb philip-lamb restored the oculus_6dof_manifest branch June 11, 2019 04:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants