Adding support for translations #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only added to main project, not to net3.5 or mobile. Those projects won't build.
… the test won't work. waiting for rebase with fix.
…ticle-translations
Missing async support.
The section translation test fails becuase I forgot to fix the async section function first. This will pass once that's merged in.
… to support loading translations with the article. Added unit tests for the Sync and Async Get Article with translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please accept the other pull request before this one. (one of the tests from this branch will fail until the other pull request is accepted)
This pull request adds support for help center translations.
It also adds the ability to side load translations when loading an article.
It includes a set of unit tests to test all of the new translation functions. (one test will fail until the other pr is merged in)
It includes two unit tests to test the side-loading of translations with articles.
In the process of creating this, I enabled the French Locale on the help center of the testing ZenDesk account.