Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated SearchForOrganizations to better reflect its purpose #236

Merged
merged 2 commits into from
Aug 26, 2016

Conversation

mwarger
Copy link
Contributor

@mwarger mwarger commented Aug 26, 2016

  • updated SearchForOrganizations to better reflect that it's searching by ExternalId
  • updated tests to actually look at externalId results
  • added DefaultExternalId setting for test

It was previously confusing to know how the search was being performed based on the method signature. This should clarify usage from a client perspective.

…by ExternalId

updated tests to actually look at externalId results
added DefaultExternalId setting for test
@mwarger
Copy link
Contributor Author

mwarger commented Aug 26, 2016

Is there any way to force this to rebuild? I don't believe the error listed in this build log is an actual error, considering the first commit passed and the second commit only had a string change...

@mozts2005 mozts2005 merged commit 1481c0c into Speedygeek:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants