Adding support for pagination in GetUsersInOrganization in the Users … #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code likely works, but please add some unit tests just to double check. |
|
@jmprovencher It should not take long I have a tool that is used to create the release notes that need to be updated but once that is done I should have it out. I am hoping to have a release this weekend. |
|
@jmprovencher Yes, I did not see that this PR was missing unit tests, please add them. I will not merge this until we have passing unit tests. |
|
I added a unit test with the paginated call but since the test instance only returns 1 user it's not that useful. @mattnis @mozts2005 |
|
This weekend would be perfect @mozts2005 🥇 Thank you for the quick feedback ! |
abc516
pushed a commit
to abc516/ZendeskApi_v2
that referenced
this pull request
Oct 30, 2019
Speedygeek#325) * Adding support for pagination in GetUsersInOrganization in the Users request. * added unit test for GetAllUsersInOrganization as a paginated call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the paginated call for GetUsersInOrganization since the maximum number of users return would only be 100 otherwise.
@mozts2005 How much time does it take to be available in a release on Nuget ? I need this change for my project. Thanks 👍