Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netstandard2.0 as target framework #334

Merged
merged 3 commits into from
Jun 23, 2018
Merged

Conversation

mbp
Copy link
Contributor

@mbp mbp commented May 17, 2018

Problem compiles fine with netstandard2.0

This should fix #235

@CLAassistant
Copy link

CLAassistant commented May 17, 2018

CLA assistant check
All committers have signed the CLA.

@AppVeyorBot
Copy link

@austingreendev
Copy link

This would be very helpful for some of the more modern core applications! Any chance of this getting merged?

@mozts2005
Copy link
Member

mozts2005 commented Jun 22, 2018

I am willing to do this. But I want to make sure the test will still pass please change the test project to be .net core.

if they pass I will then merge this.

you should only have to change the project to be netcoreapp2.0

@mozts2005 mozts2005 modified the milestone: 3.8.0 Jun 22, 2018
@AppVeyorBot
Copy link

@mbp
Copy link
Contributor Author

mbp commented Jun 22, 2018

Done, passes locally

@AppVeyorBot
Copy link

Copy link
Member

@mozts2005 mozts2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely thanks for this.

@mozts2005 mozts2005 merged commit 5a085c8 into Speedygeek:master Jun 23, 2018
@mozts2005 mozts2005 added this to the 3.9.0 milestone Jun 23, 2018
@freemstr
Copy link

Thank you
When do you think will 3.9.0 nuget package be available?
ZendeskApi_v2 is the last non-core reference I have and the above discussion is great news.

abc516 pushed a commit to abc516/ZendeskApi_v2 that referenced this pull request Oct 30, 2019
* Add netstandard2.0 as target framework

* Convert test project to netcoreapp2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.net core support?
6 participants