-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add netstandard2.0 as target framework #334
Conversation
This would be very helpful for some of the more modern core applications! Any chance of this getting merged? |
I am willing to do this. But I want to make sure the test will still pass please change the test project to be .net core. if they pass I will then merge this. you should only have to change the project to be netcoreapp2.0 |
Done, passes locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely thanks for this.
Thank you |
* Add netstandard2.0 as target framework * Convert test project to netcoreapp2.0
Problem compiles fine with netstandard2.0
This should fix #235