Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dos-style line breaks :-( #104

Open
eyalroz opened this issue Jun 28, 2021 · 4 comments
Open

dos-style line breaks :-( #104

eyalroz opened this issue Jun 28, 2021 · 4 comments

Comments

@eyalroz
Copy link

eyalroz commented Jun 28, 2021

Currently, most (but not all) files in this repository have CRLF's and end of lines - like in MS-DOS... those are quite uncommon these days. I suggest you switch to regular LF-only line breaks.

Note: I don't mean CRLFs in what's produced by the code, I mean line breaks at the end of lines in printf.c, printf.h etc.

@Gnarflord
Copy link

I'd suggest something along the lines of

char const newline[] = "\r\n";  //  Or whatever the convention is

I fully agree with you that CRLF-newlines are horrible and we should all just switch to \n but I got some test gear with very specific taste in regards to their carriage return (everything from \r\n to only \n to \n\r and some with just a random byte as "end of command"). So maybe have LF-only as the default but make it switchable inside of printf.h or something?

@eyalroz
Copy link
Author

eyalroz commented Jul 9, 2021

@Gnarflord : Oh, no, I think you misunderstood me. I mean that the source files in this repository have DOS-style line breaks. what you're suggesting is about what printf(), sprintf() etc. produce.

@Gnarflord
Copy link

Ah haha :D
Yeah of course, seems like I need another coffee. And here I was, trying to look at your changes and complaining about the github diff-tool being broken as it showed every single line being changed though they all look the same lol
Sorry to bother!

@eyalroz
Copy link
Author

eyalroz commented Jul 9, 2021

@Gnarflord : Well, regardless - this is fixed in my fork. I noticed @mpaland has been basically inactive for 2 years now, so I merged a bunch of PR's in there, and also switched to CMake for building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants