-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paths wildcard validation seems off #27
Comments
Thanks for this solid report. I'd say this comes down to a difference of opinion between the globbing library that action-validator uses, and what GitHub specifies. Might not be trivial to solve, but I'll get it figured out one way or another. |
Yeah the rust glob() function seem more "limited" in it's patterns, the equivalent of '**.md' seem to be '**/*.md' (that apparently github also understand apparently, given the 'docs/**/*.md' sample a few lines down in the same documentation. |
FWIW: The tool will also error on exclusion patterns. Example: on:
push:
branches:
- main
paths:
- '!generated/**' Adding the extra I like the idea though :-) |
I encountered this behaviour as well: https://github.com/DawnbrandBots/yaml-yugi/actions/runs/5626963939/job/15248759792 Claims the |
Hey guys, Experiencing a similar issue with Error example:
Any workaround for that? action-validator version 0.5.4 |
No workaround available, |
Experiencing a similar issue for below ci.yml
But when
|
IMO the right thing to do is disable glob validation until it can be made to match what GitHub uses. |
Hi,
Sorry if i missed something but when following the "filter pattern cheat cheet" of github action, the validator fail the file with the following message:
Glob "**.md" in on.push.paths is invalid: Pattern syntax error near position 2: recursive wildcards must form a single path component
Documentation source
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-file-paths
Sample use
Version
action-validator 0.3.0
The text was updated successfully, but these errors were encountered: