Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor Information returned on Windows through pre-commit #47

Open
jdewinter3Cloud opened this issue May 3, 2023 · 1 comment
Open

Poor Information returned on Windows through pre-commit #47

jdewinter3Cloud opened this issue May 3, 2023 · 1 comment
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work pre-commit-integration Relates to the pre-commit integration

Comments

@jdewinter3Cloud
Copy link

Tried adding this to my project, and this is what I see from output:

action validator.........................................................Failed
- hook id: action-validator
- exit code: 1

It would be helpful if there was more information on how to debug this issue, and how to see where there are bad parts of the GitHub files.

@mpalmer
Copy link
Owner

mpalmer commented May 3, 2023

The action-validator tool itself reports the nature of the failure that occurred, and the script that pre-commit uses to run action-validator does not appear to suppress that output, so this would seem to be a problem with pre-commit itself.

If there's any way that the .pre-commit-hooks.yaml that we ship could be improved, to tell pre-commit to display output on failure, I'd accept a PR to fix that, but I'm not a pre-commit user myself, and don't have a great desire to learn anything about it, so I won't be able to fix this myself. Perhaps @MatthieuBizien has some ideas, as he wrote the original pre-commit PR.

@mpalmer mpalmer added the pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work label Nov 24, 2023
@mpalmer mpalmer added the pre-commit-integration Relates to the pre-commit integration label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work pre-commit-integration Relates to the pre-commit integration
Projects
None yet
Development

No branches or pull requests

2 participants