Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In version 0.6 'normalize' is no longer an expected keyword argument in calcPSF #140

Closed
kjbrooks opened this issue Oct 11, 2016 · 2 comments

Comments

@kjbrooks
Copy link
Contributor

In testing out WebbPSF version 0.6, I found that when trying to make a simulation of the NRM mode for NIRISS, I can no longer normalize the PSF at the exit pupil (as described in the PSF Normalization section here) because the key word argument 'normalize' is unexpected.

Here is an example of what I get when I try to use 'normalize':

In [3]: niriss = webbpsf.NIRISS()

In [4]: niriss.pupil_mask = 'MASK_NRM'

In [5]: niriss.calcPSF(outfile='niriss_psf_exit.fits',normalize='exit_pupil')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-6-e3bd53f6b57e> in <module>()
----> 1 niriss.calcPSF(outfile='niriss_psf_exit.fits',normalize='exit_pupil')

TypeError: calc_psf() got an unexpected keyword argument 'normalize'
@mperrin
Copy link
Owner

mperrin commented Oct 11, 2016

This is related to #132.

Looks like the underlying issue is poppy.Instrument.calc_psf isn't passing through normalize to poppy.OpticalSystem.calc_psf.

@mperrin
Copy link
Owner

mperrin commented Oct 11, 2016

Fixed in this commit just pushed to poppy master: mperrin/poppy@cf4bdde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants