Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_legend_dots fails on matplotlib 1.4.3 #38

Open
QuLogic opened this issue May 29, 2015 · 1 comment
Open

test_legend_dots fails on matplotlib 1.4.3 #38

QuLogic opened this issue May 29, 2015 · 1 comment

Comments

@QuLogic
Copy link

QuLogic commented May 29, 2015

After applying #37, there is one more failure in the above test. It looks like the result is a little different:

opening figure
  opening axes
    draw line with 3 points
    draw 3 markers
    opening legend
    draw text 'None' None
    draw line with 2 points
    draw text 'label' None
    draw 2 markers
    draw text 'dots' None
    draw path with 4 vertices
    closing legend
  closing axes
closing figure

There's some extra text, and one less vertex in the last path.

@jakevdp
Copy link
Contributor

jakevdp commented Aug 18, 2015

Yes, currently we test with matplotlib 1.3, and I know of many such test failures with 1.4. mpld3 relies on the private matplotlib class hierarchy, which changed between versions 1.3 to 1.4 (and will likely change again with 1.5). This is not meant to be accessed outside the matplotlib package, so hacks like mpld3 will break between versions.

There doesn't seem to be motivation/time among mpld3 developers and users to track-down and fix all these issues, so for the time being I'd suggest down-grading to matplotlib 1.3. Another option is for you to join the team contribute fixes – let me know if you'd like to be involved. In any case, once MEP25 happens, we can do a re-write of the package to use this serialization interface and then (hopefully) mpld3 will not be so tied to particular matplotlib versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants