-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behaviour changed on duration = 0 or N/A tracks : Is that intentional?? #14167
Comments
Does Also please provide a sample file |
Yes, this works. Tested on v0.38.0-256-g47f60d1c and v0.37.0-161-gbd35dc8c, and with a bunch of different files having the same problem. |
Then it's entirely coincidental that your files worked in the past. This is the commit that caused the change #13254 Disabling advanced editlists support breaks multiple files from FFmpeg's FATE suite, so I don't think reverting the commit is a good idea. Can you use ffmpeg or programs that don't produce broken files to mux your videos? |
Well but I mentioned before that there's another file edit: |
Can I ask one more question a bit off-topic but still related? |
Important Information
Provide following Information:
Reproduction steps
D:\softwares\小丸工具箱rev236\tools\mp4box.exe -add "in.mp4#trackID=1:par=1:1:name=" -add "in.m4a:name=" -new "out.mp4"
using an also years-old MP4Box of GPAC version 0.5.1-DEV-rev4929mpv.exe
and bympv.com -v "out.mp4"
Expected behavior
play the video
Actual behavior
mpv v0.37.0-139-gab5b2503 (and earlier) does play the video, while v0.37.0-161-gbd35dc8c (and later) simply skips (drops) all the frames and reports
[cplayer] got EOF with no data before it
then exits (mpv window closes immediately).I'm well aware that the remuxed
out.mp4
is broken in some sense, but the fact that mpv was once able to play it makes me wonder why mpv has dropped support for playing abnormal file (by ignoring 0 or N/A duration metadata).(or DID mpv intentionally drop that "feature" in the first place (otherwise, an unwanted behaviour change)? Is there a reason why mpv just cannot ignore a track duration saying 0 or N/A? It seems to me that earlier versions of mpv followed some logic to decide ok mpv should play all frames in this specific case, but then this logic is discontinued in later versions.)
File details
Notice that
Duration: 00:00:00.08
andduration: 0
are problematic metadata caused by that MP4Box remuxing, while at the same time, that old MP4Box readsMedia Duration 00:00:32.966
andTrack has 2 edit lists: track duration is 00:00:00.041
, showing some sort of incompatibility (but yes of course, one should be now deprecated):By the way, I once suspected that the problem was FFmpeg being unable to handle multiple edit lists, but then I found two other remuxed files as counter-examples: One is produced by a browser js-based remuxer (of which I don't know the details, but I guess it contains an implementation of FFmpeg), which also contains 2 edit lists in visual track # 1 , but
ffprobe
reports normal duration time, and it is playable by all versions of mpv.The other is produced by the previously said GUI MP4Box toolchain, but due to some unknown reasons (I deleted the original video/audio stream files long ago) the
out2.mp4
has only 1 edit list in visual track # 1 , butffprobe
reports N/A or 0 duration time, and it is not playable by mpv v0.37.0-161-gbd35dc8c (and later).Log file
mpv-output.txt
ffprobe-20240518-165344.log
mpv-v0.37.0-135-output.txt
Sample files
Sample files needed to reproduce this issue can be attached to the issue
(preferred), or be uploaded to https://0x0.st/ or similar sites.
(Only needed if the issue cannot be reproduced without it.)
Do not use garbage like "cloud storage", especially not Google Drive.
The text was updated successfully, but these errors were encountered: